Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888//! End-to-end tests for the trigger-keyed scripts subsystem.//!//! Covers://! - Admin CRUD on `/admin/scripts` with trigger-id validation.//! - Dispatcher cascade for record events//! (`record.<action>:<nsid>` → `record.index:<nsid>`).//! - Label scripts: URI-routed dispatch + Record local mutation//! (`Record.delete_local`, `:save_local`).//! - The no-PDS-auth boundary: a label script that calls `r:save()`//! gets dead-lettered fail-open with the original record untouched.
mod common;
use axum::body::Body;use axum::http::{Request, StatusCode};use happyview::db::{adapt_sql, now_rfc3339};use happyview::lua::{LabelAppliedEvent, LabelHookOutcome, run_label_applied_script};use happyview::record_handler::{RecordEvent, handle_record_event};use http_body_util::BodyExt;use serde_json::{Value, json};use serial_test::serial;use tower::ServiceExt;
use common::app::TestApp;use common::fixtures;
// ---------------------------------------------------------------------------// Helpers// ---------------------------------------------------------------------------
async fn json_body(resp: axum::response::Response) -> Value { let body = resp.into_body().collect().await.unwrap().to_bytes(); serde_json::from_slice(&body).unwrap()}
fn admin_get( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue),) -> Request<Body> { Request::builder() .uri(uri) .header(cookie.0, cookie.1) .body(Body::empty()) .unwrap()}
fn admin_post( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue), body: &Value,) -> Request<Body> { Request::builder() .method("POST") .uri(uri) .header(cookie.0, cookie.1) .header("content-type", "application/json") .body(Body::from(serde_json::to_vec(body).unwrap())) .unwrap()}
fn admin_patch( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue), body: &Value,) -> Request<Body> { Request::builder() .method("PATCH") .uri(uri) .header(cookie.0, cookie.1) .header("content-type", "application/json") .body(Body::from(serde_json::to_vec(body).unwrap())) .unwrap()}
fn admin_delete( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue),) -> Request<Body> { Request::builder() .method("DELETE") .uri(uri) .header(cookie.0, cookie.1) .body(Body::empty()) .unwrap()}
/// Seed a record-type lexicon (no scripts bound — scripts live in their/// own table now, addressed by trigger id).async fn seed_lexicon(app: &TestApp, lexicon: Value) { let resp = app .router .clone() .oneshot(admin_post( "/admin/lexicons", app.admin_cookie(), &json!({ "lexicon_json": lexicon }), )) .await .unwrap(); assert!( resp.status().is_success(), "seeding lexicon failed: {:?}", resp.status() );}
/// Create a script via the admin API. Returns the created row.async fn create_script(app: &TestApp, id: &str, body: &str) -> Value { let resp = app .router .clone() .oneshot(admin_post( "/admin/scripts", app.admin_cookie(), &json!({ "id": id, "body": body }), )) .await .unwrap(); assert_eq!( resp.status(), StatusCode::CREATED, "create '{id}' failed; body: {:?}", json_body(resp).await ); let resp = app .router .clone() .oneshot(admin_get( &format!("/admin/scripts/{}", urlencoding::encode(id)), app.admin_cookie(), )) .await .unwrap(); json_body(resp).await}
async fn seed_record_row( app: &TestApp, uri: &str, did: &str, collection: &str, rkey: &str, body: Value,) { let sql = adapt_sql( "INSERT INTO happyview_records (uri, did, collection, rkey, record, cid, created_at) VALUES (?, ?, ?, ?, ?, ?, ?)", app.state.db_backend, ); happyview::db::query(&sql) .bind(uri) .bind(did) .bind(collection) .bind(rkey) .bind(serde_json::to_string(&body).unwrap_or_default()) .bind("bafyseed") .bind(now_rfc3339()) .execute(&app.state.db) .await .expect("failed to seed records row");}
async fn count_records(app: &TestApp, uri: &str) -> i64 { let (count,): (i64,) = happyview::db::query_as(&adapt_sql( "SELECT COUNT(*) FROM happyview_records WHERE uri = ?", app.state.db_backend, )) .bind(uri) .fetch_one(&app.state.db) .await .unwrap(); count}
async fn fetch_record_body(app: &TestApp, uri: &str) -> Option<Value> { let row: Option<(String,)> = happyview::db::query_as(&adapt_sql( "SELECT record FROM happyview_records WHERE uri = ?", app.state.db_backend, )) .bind(uri) .fetch_optional(&app.state.db) .await .unwrap(); row.map(|(s,)| serde_json::from_str(&s).unwrap())}
// ---------------------------------------------------------------------------// Admin CRUD// ---------------------------------------------------------------------------
#[tokio::test]#[serial]#[ignore]async fn create_then_get_script_round_trips() { let app = TestApp::new().await; let id = "record.create:com.example.thing"; create_script(&app, id, "function handle() return event.record end").await;
let resp = app .router .clone() .oneshot(admin_get( &format!("/admin/scripts/{}", urlencoding::encode(id)), app.admin_cookie(), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::OK); let row = json_body(resp).await; assert_eq!(row["id"], id); assert_eq!(row["script_type"], "lua");}
#[tokio::test]#[serial]#[ignore]async fn list_scripts_returns_all_rows() { let app = TestApp::new().await; create_script( &app, "record.create:com.example.thing", "function handle() return event.record end", ) .await; create_script( &app, "labeler.apply:_actor", "function handle() return event end", ) .await;
let resp = app .router .clone() .oneshot(admin_get("/admin/scripts", app.admin_cookie())) .await .unwrap(); assert_eq!(resp.status(), StatusCode::OK); let rows = json_body(resp).await; let arr = rows.as_array().unwrap(); assert_eq!(arr.len(), 2);}
#[tokio::test]#[serial]#[ignore]async fn create_rejects_invalid_trigger_prefix() { let app = TestApp::new().await; let resp = app .router .clone() .oneshot(admin_post( "/admin/scripts", app.admin_cookie(), &json!({ "id": "garbage:com.example.thing", "body": "function handle() end", }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::BAD_REQUEST); let err = json_body(resp).await; let msg = err["error"].as_str().unwrap_or(""); assert!( msg.contains("unknown trigger prefix"), "expected validation error, got: {msg}" );}
#[tokio::test]#[serial]#[ignore]async fn create_rejects_invalid_nsid_suffix() { let app = TestApp::new().await; // Single-segment NSID — too few segments. let resp = app .router .clone() .oneshot(admin_post( "/admin/scripts", app.admin_cookie(), &json!({ "id": "record.create:foo", "body": "function handle() end", }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
#[tokio::test]#[serial]#[ignore]async fn create_allows_labeler_apply_actor_special_case() { let app = TestApp::new().await; let resp = app .router .clone() .oneshot(admin_post( "/admin/scripts", app.admin_cookie(), &json!({ "id": "labeler.apply:_actor", "body": "function handle() return event end", }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::CREATED);}
#[tokio::test]#[serial]#[ignore]async fn create_rejects_invalid_lua_body() { let app = TestApp::new().await; let resp = app .router .clone() .oneshot(admin_post( "/admin/scripts", app.admin_cookie(), &json!({ "id": "record.create:com.example.thing", "body": "function handle(", // syntax error }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
#[tokio::test]#[serial]#[ignore]async fn patch_updates_body() { let app = TestApp::new().await; let id = "record.create:com.example.thing"; create_script(&app, id, "function handle() return event.record end").await;
let resp = app .router .clone() .oneshot(admin_patch( &format!("/admin/scripts/{}", urlencoding::encode(id)), app.admin_cookie(), &json!({ "body": "function handle() return nil end" }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::OK); let row = json_body(resp).await; assert!(row["body"].as_str().unwrap().contains("return nil"));}
#[tokio::test]#[serial]#[ignore]async fn delete_removes_script() { let app = TestApp::new().await; let id = "record.delete:com.example.thing"; create_script(&app, id, "function handle() return event.record end").await;
let resp = app .router .clone() .oneshot(admin_delete( &format!("/admin/scripts/{}", urlencoding::encode(id)), app.admin_cookie(), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get( &format!("/admin/scripts/{}", urlencoding::encode(id)), app.admin_cookie(), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::NOT_FOUND);}
// ---------------------------------------------------------------------------// Cascade resolution: action-specific row wins over wildcard// ---------------------------------------------------------------------------
#[tokio::test]#[serial]#[ignore]async fn cascade_wildcard_runs_when_no_action_specific() { let app = TestApp::new().await; seed_lexicon(&app, fixtures::game_record_lexicon()).await;
create_script( &app, "record.index:games.gamesgamesgamesgames.game", // Wildcard — uppercases the title for any action. "function handle() event.record.title = string.upper(event.record.title); return event.record end", ) .await;
let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "rkey1".into(), action: "create".into(), record: Some(json!({"title": "test game"})), cid: Some("bafy".into()), }, ) .await;
let body = fetch_record_body( &app, "at://did:plc:test/games.gamesgamesgamesgames.game/rkey1", ) .await .unwrap(); assert_eq!(body["title"], "TEST GAME");}
#[tokio::test]#[serial]#[ignore]async fn cascade_action_specific_wins_over_wildcard() { let app = TestApp::new().await; seed_lexicon(&app, fixtures::game_record_lexicon()).await;
create_script( &app, "record.index:games.gamesgamesgamesgames.game", "function handle() event.record.title = 'WILDCARD'; return event.record end", ) .await; create_script( &app, "record.create:games.gamesgamesgamesgames.game", "function handle() event.record.title = 'CREATE-SPECIFIC'; return event.record end", ) .await;
// Create action — specific should win. let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "rk-create".into(), action: "create".into(), record: Some(json!({"title": "x"})), cid: Some("bafy".into()), }, ) .await; let body = fetch_record_body( &app, "at://did:plc:test/games.gamesgamesgamesgames.game/rk-create", ) .await .unwrap(); assert_eq!(body["title"], "CREATE-SPECIFIC");
// Update action — no record.update binding → cascades to wildcard. let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "rk-update".into(), action: "update".into(), record: Some(json!({"title": "x"})), cid: Some("bafy".into()), }, ) .await; let body = fetch_record_body( &app, "at://did:plc:test/games.gamesgamesgamesgames.game/rk-update", ) .await .unwrap(); assert_eq!(body["title"], "WILDCARD");}
#[tokio::test]#[serial]#[ignore]async fn no_script_passes_record_through_unchanged() { let app = TestApp::new().await; seed_lexicon(&app, fixtures::game_record_lexicon()).await;
let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "rk1".into(), action: "create".into(), record: Some(json!({"title": "untouched"})), cid: Some("bafy".into()), }, ) .await; let body = fetch_record_body( &app, "at://did:plc:test/games.gamesgamesgamesgames.game/rk1", ) .await .unwrap(); assert_eq!(body["title"], "untouched");}
#[tokio::test]#[serial]#[ignore]async fn record_create_returning_nil_skips_indexing() { let app = TestApp::new().await; seed_lexicon(&app, fixtures::game_record_lexicon()).await;
create_script( &app, "record.create:games.gamesgamesgamesgames.game", "function handle() return nil end", ) .await;
let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "rk1".into(), action: "create".into(), record: Some(json!({"title": "doomed"})), cid: Some("bafy".into()), }, ) .await; assert_eq!( count_records( &app, "at://did:plc:test/games.gamesgamesgamesgames.game/rk1" ) .await, 0, "nil return should drop the record" );}
// ---------------------------------------------------------------------------// log() in scripts → event_logs// ---------------------------------------------------------------------------
#[tokio::test]#[serial]#[ignore]async fn record_event_script_log_writes_event_log_row() { let app = TestApp::new().await; seed_lexicon(&app, fixtures::game_record_lexicon()).await;
create_script( &app, "record.create:games.gamesgamesgamesgames.game", "function handle() log('hello from script'); return event.record end", ) .await;
let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "rk1".into(), action: "create".into(), record: Some(json!({"title": "anything"})), cid: Some("bafy".into()), }, ) .await;
// The script's log("hello from script") should land in event_logs // as a `script.log` row whose subject is the trigger id. let row: (String, String) = happyview::db::query_as(&adapt_sql( "SELECT subject, detail FROM happyview_event_logs WHERE event_type = 'script.log' ORDER BY id DESC LIMIT 1", app.state.db_backend, )) .fetch_one(&app.state.db) .await .expect("expected a script.log row"); assert_eq!(row.0, "record.create:games.gamesgamesgamesgames.game"); let detail: Value = serde_json::from_str(&row.1).unwrap(); assert_eq!(detail["message"], "hello from script"); assert_eq!( detail["trigger"], "record.create:games.gamesgamesgamesgames.game" );}
// ---------------------------------------------------------------------------// Label scripts via URI routing// ---------------------------------------------------------------------------
#[tokio::test]#[serial]#[ignore]async fn label_script_can_drop_record_via_record_delete_local() { let app = TestApp::new().await;
let uri = "at://did:plc:victim/app.bsky.feed.post/rkey1"; seed_record_row( &app, uri, "did:plc:victim", "app.bsky.feed.post", "rkey1", json!({"text": "hello"}), ) .await;
create_script( &app, "labeler.apply:app.bsky.feed.post", "function handle() \ if event.val == 'spam' then Record.delete_local(event.uri) end \ return event \ end", ) .await;
let outcome = run_label_applied_script( &app.state, LabelAppliedEvent { src: "did:plc:labeler".into(), uri: uri.into(), val: "spam".into(), neg: false, cts: now_rfc3339(), exp: None, }, ) .await; assert!(matches!(outcome, LabelHookOutcome::Continue(_))); assert_eq!(count_records(&app, uri).await, 0);}
#[tokio::test]#[serial]#[ignore]async fn label_script_can_redact_record_via_save_local() { let app = TestApp::new().await;
let uri = "at://did:plc:author/app.bsky.feed.post/rkey1"; seed_record_row( &app, uri, "did:plc:author", "app.bsky.feed.post", "rkey1", json!({"text": "original content"}), ) .await;
create_script( &app, "labeler.apply:app.bsky.feed.post", "function handle() \ if event.val == 'redact' then \ local r = Record.load(event.uri) \ if r then r.text = '[redacted by ' .. event.src .. ']'; r:save_local() end \ end; \ return event \ end", ) .await;
let outcome = run_label_applied_script( &app.state, LabelAppliedEvent { src: "did:plc:labeler".into(), uri: uri.into(), val: "redact".into(), neg: false, cts: now_rfc3339(), exp: None, }, ) .await; assert!(matches!(outcome, LabelHookOutcome::Continue(_)));
let body = fetch_record_body(&app, uri).await.unwrap(); assert_eq!(body["text"], "[redacted by did:plc:labeler]");}
#[tokio::test]#[serial]#[ignore]async fn label_script_uri_routes_actor_special_case() { let app = TestApp::new().await;
create_script( &app, "labeler.apply:_actor", // Sentinel: write a row into a caller-owned table (db.raw cannot touch // internal HappyView tables) so we can detect that the script ran. "function handle() \ db.raw('CREATE TABLE IF NOT EXISTS script_sentinel (k TEXT)') \ db.raw('INSERT INTO script_sentinel (k) VALUES (?)', {'fired'}) \ return event \ end", ) .await;
// Bare DID URI should route to `labeler.apply:_actor`. let outcome = run_label_applied_script( &app.state, LabelAppliedEvent { src: "did:plc:labeler".into(), uri: "did:plc:somebody".into(), val: "imposter".into(), neg: false, cts: now_rfc3339(), exp: None, }, ) .await; assert!(matches!(outcome, LabelHookOutcome::Continue(_)));
// Sentinel row should exist if the script ran. let (count,): (i64,) = happyview::db::query_as("SELECT COUNT(*) FROM script_sentinel WHERE k = 'fired'") .fetch_one(&app.state.db) .await .unwrap(); assert_eq!( count, 1, "labeler.apply:_actor should have fired for bare-DID label" );}
#[tokio::test]#[serial]#[ignore]async fn label_script_calling_record_save_dead_letters_with_clear_message() { let app = TestApp::new().await;
let uri = "at://did:plc:author/app.bsky.feed.post/rkey1"; seed_record_row( &app, uri, "did:plc:author", "app.bsky.feed.post", "rkey1", json!({"text": "untouched"}), ) .await;
create_script( &app, "labeler.apply:app.bsky.feed.post", "function handle() \ local r = Record.load(event.uri) \ if r then r.text = 'should fail'; r:save() end \ return event \ end", ) .await;
let outcome = run_label_applied_script( &app.state, LabelAppliedEvent { src: "did:plc:labeler".into(), uri: uri.into(), val: "anything".into(), neg: false, cts: now_rfc3339(), exp: None, }, ) .await; // Fail-open: the original label still continues even after the script // fails its retry budget. assert!(matches!(outcome, LabelHookOutcome::Continue(_)));
// The original record is unchanged. let body = fetch_record_body(&app, uri).await.unwrap(); assert_eq!(body["text"], "untouched");
// A dead-letter row exists with the NO_PDS_AUTH message. let dl: (String,) = happyview::db::query_as(&adapt_sql( "SELECT error FROM happyview_dead_letter_scripts WHERE host_kind = 'label' \ AND host_id = 'did:plc:labeler' ORDER BY id DESC LIMIT 1", app.state.db_backend, )) .fetch_one(&app.state.db) .await .expect("expected a dead_letter_scripts row"); assert!( dl.0.contains("no PDS auth"), "expected NO_PDS_AUTH message in dead-letter, got: {}", dl.0 );}
#[tokio::test]#[serial]#[ignore]async fn record_event_script_can_call_record_delete_local() { let app = TestApp::new().await; seed_lexicon(&app, fixtures::game_record_lexicon()).await;
let victim_uri = "at://did:plc:test/games.gamesgamesgamesgames.game/old"; seed_record_row( &app, victim_uri, "did:plc:test", "games.gamesgamesgamesgames.game", "old", json!({"title": "should-be-gone"}), ) .await;
create_script( &app, "record.create:games.gamesgamesgamesgames.game", "function handle() \ Record.delete_local('at://did:plc:test/games.gamesgamesgamesgames.game/old') \ return event.record \ end", ) .await;
let _ = handle_record_event( &app.state, &RecordEvent { did: "did:plc:test".into(), collection: "games.gamesgamesgamesgames.game".into(), rkey: "new1".into(), action: "create".into(), record: Some(json!({"title": "fresh game"})), cid: Some("bafy".into()), }, ) .await;
assert_eq!(count_records(&app, victim_uri).await, 0); assert_eq!( count_records( &app, "at://did:plc:test/games.gamesgamesgamesgames.game/new1" ) .await, 1 );}
// ---------------------------------------------------------------------------// Permission gating// ---------------------------------------------------------------------------
#[tokio::test]#[serial]#[ignore]async fn no_auth_returns_401() { let app = TestApp::new().await; let resp = app .router .clone() .oneshot( Request::builder() .uri("/admin/scripts") .body(Body::empty()) .unwrap(), ) .await .unwrap(); assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);}