Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427mod common;
use axum::body::Body;use axum::http::{Method, Request, StatusCode};use http_body_util::BodyExt;use serde_json::{Value, json};use serial_test::serial;use tower::ServiceExt;
use common::app::TestApp;
async fn json_body(resp: axum::response::Response) -> Value { let body = resp.into_body().collect().await.unwrap().to_bytes(); serde_json::from_slice(&body).unwrap()}
fn admin_get( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue),) -> Request<Body> { Request::builder() .uri(uri) .header(cookie.0, cookie.1) .body(Body::empty()) .unwrap()}
fn admin_put( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue), body: &Value,) -> Request<Body> { Request::builder() .method(Method::PUT) .uri(uri) .header(cookie.0, cookie.1) .header("content-type", "application/json") .body(Body::from(serde_json::to_vec(body).unwrap())) .unwrap()}
#[tokio::test]#[serial]async fn get_proxy_config_returns_default() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap();
assert_eq!(resp.status(), StatusCode::OK); let json = json_body(resp).await; assert_eq!(json["mode"], "open"); assert_eq!(json["nsids"], json!([]));}
#[tokio::test]#[serial]async fn put_and_get_allowlist() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "allowlist", "nsids": ["com.example.feed.*", "com.other.thing.getStuff"] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap();
assert_eq!(resp.status(), StatusCode::OK); let json = json_body(resp).await; assert_eq!(json["mode"], "allowlist"); assert_eq!( json["nsids"], json!(["com.example.feed.*", "com.other.thing.getStuff"]) );}
/// Routing and mode are independent axes, and the dashboard's proxy-mode form/// only sends `mode` and `nsids`. An omitted `routing` therefore has to mean/// "leave it alone" — if it meant "use the default", every mode toggle would/// silently revert an operator's routing choice.#[tokio::test]#[serial]async fn put_without_routing_preserves_the_stored_routing() { common::require_db!(); let app = TestApp::new().await;
// Opt in to service proxying. let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "open", "nsids": [], "routing": "serviceproxy" }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::NO_CONTENT);
// Now change only the mode, exactly as the dashboard form does. let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "allowlist", "nsids": ["com.example.*"] }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap(); let json = json_body(resp).await; assert_eq!(json["mode"], "allowlist"); assert_eq!( json["routing"], "serviceproxy", "changing the mode must not reset routing" );}
#[tokio::test]#[serial]async fn put_can_change_routing_explicitly() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "open", "nsids": [], "routing": "serviceproxy" }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap(); assert_eq!(json_body(resp).await["routing"], "serviceproxy");
// And back again. let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "open", "nsids": [], "routing": "authority" }), )) .await .unwrap(); assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap(); assert_eq!(json_body(resp).await["routing"], "authority");}
/// A fresh instance must not be service-proxying until someone asks for it.#[tokio::test]#[serial]async fn default_routing_is_authority() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap(); assert_eq!(json_body(resp).await["routing"], "authority");}
#[tokio::test]#[serial]async fn disabled_mode_clears_nsids() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "disabled", "nsids": ["com.example.*"] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap();
let json = json_body(resp).await; assert_eq!(json["mode"], "disabled"); assert_eq!(json["nsids"], json!([]));}
#[tokio::test]#[serial]async fn invalid_mode_rejected() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "yolo", "nsids": [] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::UNPROCESSABLE_ENTITY);}
#[tokio::test]#[serial]async fn invalid_nsid_rejected() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "allowlist", "nsids": ["*"] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
#[tokio::test]#[serial]async fn put_and_get_blocklist() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "blocklist", "nsids": ["com.blocked.feed.*"] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap();
assert_eq!(resp.status(), StatusCode::OK); let json = json_body(resp).await; assert_eq!(json["mode"], "blocklist"); assert_eq!(json["nsids"], json!(["com.blocked.feed.*"]));}
#[tokio::test]#[serial]async fn put_keeping_stored_legacy_pattern_succeeds() { common::require_db!(); let app = TestApp::new().await;
// Seed the in-memory config with a pattern the current validator would // reject (a hyphen at the end of a domain-label segment) but an older, // laxer validator once accepted. This simulates a legacy stored config. app.state .proxy_config .store(std::sync::Arc::new(happyview::proxy_config::ProxyConfig { mode: happyview::proxy_config::ProxyMode::Allowlist, routing: happyview::proxy_config::ProxyRouting::Authority, nsids: vec!["com.foo-.*".to_string()], }));
// Re-submitting the exact same, already-stored pattern must not 400 — // it's grandfathered rather than revalidated. let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "allowlist", "nsids": ["com.foo-.*"] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::NO_CONTENT);
let resp = app .router .clone() .oneshot(admin_get("/admin/settings/xrpc-proxy", app.admin_cookie())) .await .unwrap(); let json = json_body(resp).await; assert_eq!(json["nsids"], json!(["com.foo-.*"]));}
#[tokio::test]#[serial]async fn put_adding_new_invalid_pattern_alongside_stored_legacy_one_is_rejected() { common::require_db!(); let app = TestApp::new().await;
app.state .proxy_config .store(std::sync::Arc::new(happyview::proxy_config::ProxyConfig { mode: happyview::proxy_config::ProxyMode::Allowlist, routing: happyview::proxy_config::ProxyRouting::Authority, nsids: vec!["com.foo-.*".to_string()], }));
// The stored legacy pattern is grandfathered, but a brand-new invalid // pattern alongside it must still be rejected — the check is narrowed, // not removed. let resp = app .router .clone() .oneshot(admin_put( "/admin/settings/xrpc-proxy", app.admin_cookie(), &json!({ "mode": "allowlist", "nsids": ["com.foo-.*", "*"] }), )) .await .unwrap();
assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
#[tokio::test]#[serial]async fn requires_auth() { common::require_db!(); let app = TestApp::new().await;
let resp = app .router .clone() .oneshot( Request::builder() .uri("/admin/settings/xrpc-proxy") .body(Body::empty()) .unwrap(), ) .await .unwrap();
assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);}