Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569mod common;
use axum::body::Body;use axum::http::{Request, StatusCode};use happyview::db::adapt_sql;use happyview::oauth::pds_write::generate_dpop_proof;use http_body_util::BodyExt;use serde_json::{Value, json};use serial_test::serial;use tower::ServiceExt;use wiremock::matchers::{method, path};use wiremock::{Mock, ResponseTemplate};
// ---------------------------------------------------------------------------// Helpers// ---------------------------------------------------------------------------
async fn response_json(resp: axum::response::Response) -> Value { let body = resp.into_body().collect().await.unwrap().to_bytes(); serde_json::from_slice(&body).unwrap_or(json!(null))}
fn post_json_with_headers(uri: &str, body: &Value, headers: Vec<(&str, &str)>) -> Request<Body> { let mut builder = Request::builder() .method("POST") .uri(uri) .header("content-type", "application/json") .header("host", "127.0.0.1:0"); for (name, value) in headers { builder = builder.header(name, value); } builder .body(Body::from(serde_json::to_vec(body).unwrap())) .unwrap()}
fn get_with_headers(uri: &str, headers: Vec<(&str, &str)>) -> Request<Body> { let mut builder = Request::builder() .method("GET") .uri(uri) .header("host", "127.0.0.1:0"); for (name, value) in headers { builder = builder.header(name, value); } builder.body(Body::empty()).unwrap()}
/// Set up a full DPoP session and return `(client_key, dpop_key, access_token)`.async fn setup_dpop_session(app: &common::app::TestApp, user_did: &str) -> (String, Value, String) { let (client_key, client_secret, _id) = app.create_api_client("confidential", None).await;
let key_req = post_json_with_headers( "/oauth/dpop-keys", &json!({}), vec![ ("x-client-key", &client_key), ("x-client-secret", &client_secret), ], ); let key_resp = app.router.clone().oneshot(key_req).await.unwrap(); assert_eq!(key_resp.status(), StatusCode::CREATED); let key_body = response_json(key_resp).await; let provision_id = key_body["provision_id"].as_str().unwrap().to_string(); let dpop_key = key_body["dpop_key"].clone();
let access_token = format!("test-access-{}", uuid::Uuid::new_v4()); app.mock_session_verification(user_did, user_did).await; let session_req = post_json_with_headers( "/oauth/sessions", &json!({ "provision_id": provision_id, "did": user_did, "access_token": &access_token, "scopes": "atproto", "pds_url": "https://pds.example.com", }), vec![ ("x-client-key", &client_key), ("x-client-secret", &client_secret), ], ); let session_resp = app.router.clone().oneshot(session_req).await.unwrap(); assert_eq!(session_resp.status(), StatusCode::CREATED);
(client_key, dpop_key, access_token)}
/// Build DPoP auth headers for a request.fn dpop_auth_headers<'a>( client_key: &'a str, dpop_key: &Value, access_token: &'a str, method: &str, url: &str,) -> Vec<(&'static str, String)> { // DPoP htu must not include query/fragment let htu = url.split('?').next().unwrap_or(url); let proof = generate_dpop_proof(dpop_key, method, htu, access_token, None) .expect("failed to generate DPoP proof"); vec![ ("x-client-key", client_key.to_string()), ("authorization", format!("DPoP {}", access_token)), ("dpop", proof), ]}
/// Make an authenticated POST request.async fn dpop_post( app: &common::app::TestApp, path: &str, body: &Value, client_key: &str, dpop_key: &Value, access_token: &str,) -> axum::response::Response { let url = format!("http://127.0.0.1:0{}", path); let headers = dpop_auth_headers(client_key, dpop_key, access_token, "POST", &url); let str_headers: Vec<(&str, &str)> = headers.iter().map(|(k, v)| (*k, v.as_str())).collect(); let req = post_json_with_headers(path, body, str_headers); app.router.clone().oneshot(req).await.unwrap()}
/// Make an authenticated GET request.async fn dpop_get( app: &common::app::TestApp, path: &str, client_key: &str, dpop_key: &Value, access_token: &str,) -> axum::response::Response { let url = format!("http://127.0.0.1:0{}", path); let headers = dpop_auth_headers(client_key, dpop_key, access_token, "GET", &url); let str_headers: Vec<(&str, &str)> = headers.iter().map(|(k, v)| (*k, v.as_str())).collect(); let req = get_with_headers(path, str_headers); app.router.clone().oneshot(req).await.unwrap()}
/// Register a DPoP session for a target DID using the same API client./// This simulates the client completing OAuth for the target account.async fn register_target_session( app: &common::app::TestApp, client_key: &str, client_secret: &str, target_did: &str,) { // Look up the client secret from the DB — we need it for the dpop-keys endpoint. // Actually, setup_dpop_session already provisions a key, but we need a separate session // for the target DID under the same api_client. // We can reuse the same provision_id (DPoP key) — register another session with a // different DID.
// Provision a new DPoP key for this target session let key_req = post_json_with_headers( "/oauth/dpop-keys", &json!({}), vec![ ("x-client-key", client_key), ("x-client-secret", client_secret), ], ); let key_resp = app.router.clone().oneshot(key_req).await.unwrap(); assert_eq!(key_resp.status(), StatusCode::CREATED); let key_body = response_json(key_resp).await; let provision_id = key_body["provision_id"].as_str().unwrap().to_string();
let access_token = format!("test-target-access-{}", uuid::Uuid::new_v4()); app.mock_session_verification(target_did, target_did).await; let session_req = post_json_with_headers( "/oauth/sessions", &json!({ "provision_id": provision_id, "did": target_did, "access_token": &access_token, "scopes": "atproto", "pds_url": "https://pds.example.com", }), vec![ ("x-client-key", client_key), ("x-client-secret", client_secret), ], ); let session_resp = app.router.clone().oneshot(session_req).await.unwrap(); assert_eq!( session_resp.status(), StatusCode::CREATED, "failed to register target session" );}
/// Full setup: create an API client, register DPoP sessions for both the owner/// and the target account, then call linkAccount./// Returns `(client_key, client_secret, dpop_key, access_token)`.async fn setup_linked_account( app: &common::app::TestApp, owner_did: &str, target_did: &str,) -> (String, String, Value, String) { let (client_key, client_secret, _id) = app.create_api_client("confidential", None).await;
// Provision DPoP key + session for the owner let key_req = post_json_with_headers( "/oauth/dpop-keys", &json!({}), vec![ ("x-client-key", &client_key), ("x-client-secret", &client_secret), ], ); let key_resp = app.router.clone().oneshot(key_req).await.unwrap(); assert_eq!(key_resp.status(), StatusCode::CREATED); let key_body = response_json(key_resp).await; let provision_id = key_body["provision_id"].as_str().unwrap().to_string(); let dpop_key = key_body["dpop_key"].clone();
let access_token = format!("test-owner-access-{}", uuid::Uuid::new_v4()); app.mock_session_verification(owner_did, owner_did).await; let session_req = post_json_with_headers( "/oauth/sessions", &json!({ "provision_id": provision_id, "did": owner_did, "access_token": &access_token, "scopes": "atproto", "pds_url": "https://pds.example.com", }), vec![ ("x-client-key", &client_key), ("x-client-secret", &client_secret), ], ); let session_resp = app.router.clone().oneshot(session_req).await.unwrap(); assert_eq!(session_resp.status(), StatusCode::CREATED);
// Register a session for the target account under the same API client register_target_session(app, &client_key, &client_secret, target_did).await;
// Link the account let resp = dpop_post( app, "/xrpc/dev.happyview.delegation.linkAccount", &json!({ "did": target_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED, "linkAccount failed");
(client_key, client_secret, dpop_key, access_token)}
/// Provision a DPoP session for a user under an existing API client./// Returns `(dpop_key, access_token)` — use the shared `client_key` for requests.async fn setup_session_for_client( app: &common::app::TestApp, client_key: &str, client_secret: &str, user_did: &str,) -> (Value, String) { let key_req = post_json_with_headers( "/oauth/dpop-keys", &json!({}), vec![ ("x-client-key", client_key), ("x-client-secret", client_secret), ], ); let key_resp = app.router.clone().oneshot(key_req).await.unwrap(); assert_eq!(key_resp.status(), StatusCode::CREATED); let key_body = response_json(key_resp).await; let provision_id = key_body["provision_id"].as_str().unwrap().to_string(); let dpop_key = key_body["dpop_key"].clone();
let access_token = format!("test-access-{}", uuid::Uuid::new_v4()); app.mock_session_verification(user_did, user_did).await; let session_req = post_json_with_headers( "/oauth/sessions", &json!({ "provision_id": provision_id, "did": user_did, "access_token": &access_token, "scopes": "atproto", "pds_url": "https://pds.example.com", }), vec![ ("x-client-key", client_key), ("x-client-secret", client_secret), ], ); let session_resp = app.router.clone().oneshot(session_req).await.unwrap(); assert_eq!(session_resp.status(), StatusCode::CREATED);
(dpop_key, access_token)}
// ---------------------------------------------------------------------------// linkAccount// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn link_account_success() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:owner1"; let target_did = "did:plc:studio1";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
// Verify via getAccount let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.getAccount?did={}", target_did ), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; assert_eq!(body["did"], target_did); assert_eq!(body["role"], "owner"); assert_eq!(body["linkedBy"], owner_did);}
#[tokio::test]#[serial]async fn link_account_already_linked() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:owner2"; let target_did = "did:plc:studio2";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
// Try to link again let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.linkAccount", &json!({ "did": target_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::CONFLICT);}
#[tokio::test]#[serial]async fn link_account_self_link_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let user_did = "did:plc:selflinker";
let (client_key, dpop_key, access_token) = setup_dpop_session(&app, user_did).await;
let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.linkAccount", &json!({ "did": user_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
#[tokio::test]#[serial]async fn link_account_no_session_for_target() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:owner3"; let target_did = "did:plc:nosession";
let (client_key, dpop_key, access_token) = setup_dpop_session(&app, owner_did).await;
// Don't register a session for target_did — should fail let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.linkAccount", &json!({ "did": target_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
// ---------------------------------------------------------------------------// unlinkAccount// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn unlink_account_success() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:unlink_owner"; let target_did = "did:plc:unlink_studio";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.unlinkAccount", &json!({ "did": target_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::OK);
// Verify account is gone let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.getAccount?did={}", target_did ), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::NOT_FOUND);}
#[tokio::test]#[serial]async fn unlink_account_non_owner_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:unlink_owner2"; let admin_did = "did:plc:unlink_admin2"; let target_did = "did:plc:unlink_studio2";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add an admin let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Admin tries to unlink — should be rejected (owner-only) let (admin_dpop, admin_token) = setup_session_for_client(&app, &owner_key, &owner_secret, admin_did).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.unlinkAccount", &json!({ "did": target_did }), &owner_key, &admin_dpop, &admin_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
// ---------------------------------------------------------------------------// addDelegate// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn add_delegate_success() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:add_owner"; let member_did = "did:plc:add_member"; let target_did = "did:plc:add_studio";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Verify via listDelegates let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; let delegates = body["delegates"].as_array().unwrap(); assert_eq!(delegates.len(), 2); // owner + member let member = delegates .iter() .find(|d| d["userDid"] == member_did) .unwrap(); assert_eq!(member["role"], "member"); assert_eq!(member["grantedBy"], owner_did);}
#[tokio::test]#[serial]async fn add_delegate_owner_role_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:add_owner2"; let target_did = "did:plc:add_studio2";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": "did:plc:someone", "role": "owner" }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::BAD_REQUEST);}
#[tokio::test]#[serial]async fn add_delegate_already_exists() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:add_owner3"; let member_did = "did:plc:add_member3"; let target_did = "did:plc:add_studio3";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add member let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Try to add again let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "admin" }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::CONFLICT);}
#[tokio::test]#[serial]async fn add_delegate_member_cannot_add() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:add_owner4"; let member_did = "did:plc:add_member4"; let target_did = "did:plc:add_studio4";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add a member let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Member tries to add another delegate — should fail (members can't manage) let (member_dpop, member_token) = setup_session_for_client(&app, &owner_key, &owner_secret, member_did).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": "did:plc:someone", "role": "member" }), &owner_key, &member_dpop, &member_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
// ---------------------------------------------------------------------------// removeDelegate// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn remove_delegate_success() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:rm_owner"; let member_did = "did:plc:rm_member"; let target_did = "did:plc:rm_studio";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add then remove a member dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &client_key, &dpop_key, &access_token, ) .await;
let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.removeDelegate", &json!({ "accountDid": target_did, "userDid": member_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::OK);
// Verify only owner remains let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &client_key, &dpop_key, &access_token, ) .await; let body = response_json(resp).await; let delegates = body["delegates"].as_array().unwrap(); assert_eq!(delegates.len(), 1); assert_eq!(delegates[0]["role"], "owner");}
#[tokio::test]#[serial]async fn remove_delegate_cannot_remove_owner() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:rm_owner2"; let target_did = "did:plc:rm_studio2";
let (client_key, _client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, target_did).await;
let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.removeDelegate", &json!({ "accountDid": target_did, "userDid": owner_did }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
#[tokio::test]#[serial]async fn remove_delegate_admin_cannot_remove_admin() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:rm_owner3"; let admin1_did = "did:plc:rm_admin3a"; let admin2_did = "did:plc:rm_admin3b"; let target_did = "did:plc:rm_studio3";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add two admins dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin1_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await; dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin2_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Admin1 tries to remove admin2 let (a1_dpop, a1_token) = setup_session_for_client(&app, &owner_key, &owner_secret, admin1_did).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.removeDelegate", &json!({ "accountDid": target_did, "userDid": admin2_did }), &owner_key, &a1_dpop, &a1_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
// ---------------------------------------------------------------------------// listAccounts// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn list_accounts_returns_linked_accounts() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:list_owner"; let studio1 = "did:plc:list_studio1"; let studio2 = "did:plc:list_studio2";
let (client_key, client_secret, dpop_key, access_token) = setup_linked_account(&app, owner_did, studio1).await;
// Link a second account under the same API client register_target_session(&app, &client_key, &client_secret, studio2).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.linkAccount", &json!({ "did": studio2 }), &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// List accounts — should include both let resp = dpop_get( &app, "/xrpc/dev.happyview.delegation.listAccounts", &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; let accounts = body["accounts"].as_array().unwrap(); assert_eq!(accounts.len(), 2);}
#[tokio::test]#[serial]async fn list_accounts_empty() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let user_did = "did:plc:no_accounts";
let (client_key, dpop_key, access_token) = setup_dpop_session(&app, user_did).await;
let resp = dpop_get( &app, "/xrpc/dev.happyview.delegation.listAccounts", &client_key, &dpop_key, &access_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; let accounts = body["accounts"].as_array().unwrap(); assert!(accounts.is_empty());}
// ---------------------------------------------------------------------------// getAccount// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn get_account_not_a_delegate() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:ga_owner"; let target_did = "did:plc:ga_studio";
let (owner_key, owner_secret, _owner_dpop, _owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Different user (same app, but not a delegate) tries to get account details let outsider_did = "did:plc:ga_outsider"; let (out_dpop, out_token) = setup_session_for_client(&app, &owner_key, &owner_secret, outsider_did).await; let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.getAccount?did={}", target_did ), &owner_key, &out_dpop, &out_token, ) .await; assert_eq!(resp.status(), StatusCode::NOT_FOUND);}
// ---------------------------------------------------------------------------// listDelegates// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn list_delegates_member_cannot_list() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:ld_owner"; let member_did = "did:plc:ld_member"; let target_did = "did:plc:ld_studio";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add a member dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Member tries to list delegates (same client, but member role can't list) let (member_dpop, member_token) = setup_session_for_client(&app, &owner_key, &owner_secret, member_did).await; let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &owner_key, &member_dpop, &member_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
// ---------------------------------------------------------------------------// DelegateRole unit tests (no TestApp needed)// ---------------------------------------------------------------------------
#[test]fn delegate_role_from_str_roundtrip() { use happyview::delegation::DelegateRole; for role in &[ DelegateRole::Owner, DelegateRole::Admin, DelegateRole::Member, ] { let s = role.as_str(); assert_eq!(DelegateRole::from_str(s), Some(*role)); } assert_eq!(DelegateRole::from_str("invalid"), None);}
#[test]fn delegate_role_can_write() { use happyview::delegation::DelegateRole; assert!(DelegateRole::Owner.can_write()); assert!(DelegateRole::Admin.can_write()); assert!(!DelegateRole::Member.can_write());}
#[test]fn delegate_role_can_manage_members() { use happyview::delegation::DelegateRole; assert!(DelegateRole::Owner.can_manage_members()); assert!(DelegateRole::Admin.can_manage_members()); assert!(!DelegateRole::Member.can_manage_members());}
// ---------------------------------------------------------------------------// Helpers for delegated write tests// ---------------------------------------------------------------------------
fn admin_post_request( uri: &str, cookie: (axum::http::HeaderName, axum::http::HeaderValue), body: &Value,) -> Request<Body> { Request::builder() .method("POST") .uri(uri) .header(cookie.0, cookie.1) .header("content-type", "application/json") .header("host", "127.0.0.1:0") .body(Body::from(serde_json::to_vec(body).unwrap())) .unwrap()}
async fn seed_procedure_lexicon(app: &common::app::TestApp) { let resp = app .router .clone() .oneshot(admin_post_request( "/admin/lexicons", app.admin_cookie(), &json!({ "lexicon_json": common::fixtures::create_game_procedure_lexicon(), "target_collection": "games.gamesgamesgamesgames.game" }), )) .await .unwrap(); assert!( resp.status().is_success(), "failed to seed procedure lexicon: {}", resp.status() );}
async fn update_session_pds_url(app: &common::app::TestApp, user_did: &str, pds_url: &str) { let sql = adapt_sql( "UPDATE happyview_dpop_sessions SET pds_url = ? WHERE user_did = ?", app.state.db_backend, ); happyview::db::query(&sql) .bind(pds_url) .bind(user_did) .execute(&app.state.db) .await .expect("failed to update session pds_url");}
// ---------------------------------------------------------------------------// Delegated writes — auth gates// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn delegated_write_non_delegate_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; seed_procedure_lexicon(&app).await;
let owner_did = "did:plc:dw_owner1"; let target_did = "did:plc:dw_studio1"; setup_linked_account(&app, owner_did, target_did).await;
// Outsider (not a delegate) tries a delegated write let outsider_did = "did:plc:dw_outsider1"; let (out_key, out_dpop, out_token) = setup_dpop_session(&app, outsider_did).await;
let resp = dpop_post( &app, "/xrpc/games.gamesgamesgamesgames.createGame", &json!({ "title": "Hacked Game", "delegateDid": target_did }), &out_key, &out_dpop, &out_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
#[tokio::test]#[serial]async fn delegated_write_member_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; seed_procedure_lexicon(&app).await;
let owner_did = "did:plc:dw_owner2"; let member_did = "did:plc:dw_member2"; let target_did = "did:plc:dw_studio2";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add a member (cannot write) let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Member tries a delegated write (same client, but member role can't write) let (mem_dpop, mem_token) = setup_session_for_client(&app, &owner_key, &owner_secret, member_did).await; let resp = dpop_post( &app, "/xrpc/games.gamesgamesgamesgames.createGame", &json!({ "title": "Member Game", "delegateDid": target_did }), &owner_key, &mem_dpop, &mem_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
// ---------------------------------------------------------------------------// Delegated writes — happy path// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn delegated_write_owner_success() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; seed_procedure_lexicon(&app).await;
let owner_did = "did:plc:dw_owner3"; let target_did = "did:plc:dw_studio3";
let (owner_key, _owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Point the target's DPoP session at the mock server so dpop_pds_post // reaches wiremock instead of a real PDS. let mock_url = app.mock_server.uri(); update_session_pds_url(&app, target_did, &mock_url).await;
// Mock PDS createRecord Mock::given(method("POST")) .and(path("/xrpc/com.atproto.repo.createRecord")) .respond_with(ResponseTemplate::new(200).set_body_json(json!({ "uri": format!("at://{target_did}/games.gamesgamesgamesgames.game/abc123"), "cid": "bafytest123" }))) .expect(1) .mount(&app.mock_server) .await;
let resp = dpop_post( &app, "/xrpc/games.gamesgamesgamesgames.createGame", &json!({ "title": "Studio Game", "delegateDid": target_did }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::OK);
let body = response_json(resp).await; assert_eq!( body["uri"], format!("at://{target_did}/games.gamesgamesgamesgames.game/abc123") ); assert_eq!(body["cid"], "bafytest123");}
#[tokio::test]#[serial]async fn delegated_write_admin_success() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; seed_procedure_lexicon(&app).await;
let owner_did = "did:plc:dw_owner4"; let admin_did = "did:plc:dw_admin4"; let target_did = "did:plc:dw_studio4";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add an admin let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Point the target's DPoP session at the mock server let mock_url = app.mock_server.uri(); update_session_pds_url(&app, target_did, &mock_url).await;
// Mock PDS createRecord Mock::given(method("POST")) .and(path("/xrpc/com.atproto.repo.createRecord")) .respond_with(ResponseTemplate::new(200).set_body_json(json!({ "uri": format!("at://{target_did}/games.gamesgamesgamesgames.game/def456"), "cid": "bafyadmin456" }))) .expect(1) .mount(&app.mock_server) .await;
// Admin does a delegated write (same client) let (adm_dpop, adm_token) = setup_session_for_client(&app, &owner_key, &owner_secret, admin_did).await; let resp = dpop_post( &app, "/xrpc/games.gamesgamesgamesgames.createGame", &json!({ "title": "Admin Game", "delegateDid": target_did }), &owner_key, &adm_dpop, &adm_token, ) .await; assert_eq!(resp.status(), StatusCode::OK);
let body = response_json(resp).await; assert_eq!(body["cid"], "bafyadmin456");}
// ---------------------------------------------------------------------------// Positive-path coverage for admin / member operations// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn admin_can_add_delegate() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await;
let owner_did = "did:plc:acd_owner"; let admin_did = "did:plc:acd_admin"; let new_member_did = "did:plc:acd_newmember"; let target_did = "did:plc:acd_studio";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Owner adds admin let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Admin adds a member (same client) let (adm_dpop, adm_token) = setup_session_for_client(&app, &owner_key, &owner_secret, admin_did).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": new_member_did, "role": "member" }), &owner_key, &adm_dpop, &adm_token, ) .await; assert_eq!(resp.status(), StatusCode::CREATED);
// Verify the member exists via listDelegates (as owner) let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; let delegates = body["delegates"].as_array().unwrap(); assert_eq!(delegates.len(), 3); // owner + admin + member let member = delegates .iter() .find(|d| d["userDid"] == new_member_did) .unwrap(); assert_eq!(member["role"], "member"); assert_eq!(member["grantedBy"], admin_did);}
#[tokio::test]#[serial]async fn admin_can_remove_member() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await;
let owner_did = "did:plc:arm_owner"; let admin_did = "did:plc:arm_admin"; let member_did = "did:plc:arm_member"; let target_did = "did:plc:arm_studio";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Owner adds admin and member dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await; dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Admin removes member (same client) let (adm_dpop, adm_token) = setup_session_for_client(&app, &owner_key, &owner_secret, admin_did).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.removeDelegate", &json!({ "accountDid": target_did, "userDid": member_did }), &owner_key, &adm_dpop, &adm_token, ) .await; assert_eq!(resp.status(), StatusCode::OK);
// Verify member is gone let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &owner_key, &owner_dpop, &owner_token, ) .await; let body = response_json(resp).await; let delegates = body["delegates"].as_array().unwrap(); assert_eq!(delegates.len(), 2); // owner + admin only assert!(delegates.iter().all(|d| d["userDid"] != member_did));}
#[tokio::test]#[serial]async fn admin_can_list_delegates() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await;
let owner_did = "did:plc:ald_owner"; let admin_did = "did:plc:ald_admin"; let target_did = "did:plc:ald_studio";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Owner adds admin dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Admin lists delegates (same client) let (adm_dpop, adm_token) = setup_session_for_client(&app, &owner_key, &owner_secret, admin_did).await; let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &owner_key, &adm_dpop, &adm_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; let delegates = body["delegates"].as_array().unwrap(); assert_eq!(delegates.len(), 2); // owner + admin}
#[tokio::test]#[serial]async fn member_can_view_account() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await;
let owner_did = "did:plc:mva_owner"; let member_did = "did:plc:mva_member"; let target_did = "did:plc:mva_studio";
let (owner_key, owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Owner adds member dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": member_did, "role": "member" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Member calls getAccount (same client) let (mem_dpop, mem_token) = setup_session_for_client(&app, &owner_key, &owner_secret, member_did).await; let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.getAccount?did={}", target_did ), &owner_key, &mem_dpop, &mem_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; assert_eq!(body["did"], target_did); assert_eq!(body["role"], "member");}
#[tokio::test]#[serial]async fn owner_can_remove_admin() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await;
let owner_did = "did:plc:ora_owner"; let admin_did = "did:plc:ora_admin"; let target_did = "did:plc:ora_studio";
let (owner_key, _owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Owner adds admin dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Owner removes admin let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.removeDelegate", &json!({ "accountDid": target_did, "userDid": admin_did }), &owner_key, &owner_dpop, &owner_token, ) .await; assert_eq!(resp.status(), StatusCode::OK);
// Verify only owner remains let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.listDelegates?accountDid={}", target_did ), &owner_key, &owner_dpop, &owner_token, ) .await; let body = response_json(resp).await; let delegates = body["delegates"].as_array().unwrap(); assert_eq!(delegates.len(), 1); assert_eq!(delegates[0]["role"], "owner");}
// ---------------------------------------------------------------------------// Cross-client scoping — operations from a different API client are rejected// ---------------------------------------------------------------------------
#[tokio::test]#[serial]async fn cross_client_get_account_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:xc_ga_owner"; let target_did = "did:plc:xc_ga_studio";
setup_linked_account(&app, owner_did, target_did).await;
// Different API client tries to access the account let (other_key, other_dpop, other_token) = setup_dpop_session(&app, owner_did).await; let resp = dpop_get( &app, &format!( "/xrpc/dev.happyview.delegation.getAccount?did={}", target_did ), &other_key, &other_dpop, &other_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
#[tokio::test]#[serial]async fn cross_client_add_delegate_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:xc_ad_owner"; let target_did = "did:plc:xc_ad_studio";
setup_linked_account(&app, owner_did, target_did).await;
// Different API client tries to add a delegate let (other_key, other_dpop, other_token) = setup_dpop_session(&app, owner_did).await; let resp = dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": "did:plc:xc_someone", "role": "member" }), &other_key, &other_dpop, &other_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
#[tokio::test]#[serial]async fn cross_client_delegated_write_rejected() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; seed_procedure_lexicon(&app).await;
let owner_did = "did:plc:xc_dw_owner"; let admin_did = "did:plc:xc_dw_admin"; let target_did = "did:plc:xc_dw_studio";
let (owner_key, _owner_secret, owner_dpop, owner_token) = setup_linked_account(&app, owner_did, target_did).await;
// Add an admin under the correct client dpop_post( &app, "/xrpc/dev.happyview.delegation.addDelegate", &json!({ "accountDid": target_did, "userDid": admin_did, "role": "admin" }), &owner_key, &owner_dpop, &owner_token, ) .await;
// Admin authenticates via a different API client and tries a delegated write let (other_key, other_dpop, other_token) = setup_dpop_session(&app, admin_did).await; let resp = dpop_post( &app, "/xrpc/games.gamesgamesgamesgames.createGame", &json!({ "title": "Cross-client Game", "delegateDid": target_did }), &other_key, &other_dpop, &other_token, ) .await; assert_eq!(resp.status(), StatusCode::FORBIDDEN);}
#[tokio::test]#[serial]async fn cross_client_list_accounts_isolated() { common::require_db!(); let app = common::app::TestApp::new_with_encryption().await; let owner_did = "did:plc:xc_la_owner"; let studio1 = "did:plc:xc_la_studio1"; let studio2 = "did:plc:xc_la_studio2";
// Link studio1 under client A setup_linked_account(&app, owner_did, studio1).await;
// Link studio2 under client B (different API client) let (client_b_key, _client_b_secret, client_b_dpop, client_b_token) = setup_linked_account(&app, owner_did, studio2).await;
// listAccounts from client B should only show studio2 let resp = dpop_get( &app, "/xrpc/dev.happyview.delegation.listAccounts", &client_b_key, &client_b_dpop, &client_b_token, ) .await; assert_eq!(resp.status(), StatusCode::OK); let body = response_json(resp).await; let accounts = body["accounts"].as_array().unwrap(); assert_eq!(accounts.len(), 1); assert_eq!(accounts[0]["did"], studio2);}