From 3f4d959d3b8631ef6385a047d7ee89a90de0476d Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 21 Oct 2026 20:39:54 +0000 Subject: [PATCH] ci: correct why the PPA install fails The PPA's fish 4.9.3 build was fine. The failing runs came from 503s on Launchpad: apt-get update only warned, and apt-get install fish silently fell back to Ubuntu's own fish 3.7.0, which is the one printing the terminal warnings. Say so in the action's description. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01PVbQM4XyH5HLzapJWmWTU1 --- .github/actions/install-fish-linux/action.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/actions/install-fish-linux/action.yml b/.github/actions/install-fish-linux/action.yml index ad63e8d..61d823c 100644 --- a/.github/actions/install-fish-linux/action.yml +++ b/.github/actions/install-fish-linux/action.yml @@ -4,12 +4,14 @@ description: >- Installs fish's standalone Linux build from its GitHub release, as /usr/bin/fish plus a /usr/bin/fish_indent link to the same binary. - fish-shop/install-fish-shell installs from the Launchpad PPA on Linux, - which is used instead because the PPA's fish 4.9.3 build can't load any - terminal definition on the runner (every interactive test shell printed - "Could not set up terminal" warnings that the tests count as stray - output), and the PPA has been returning 503s. /usr/bin is where - fish-shop/install-plugin-manager expects fish. + Used instead of fish-shop/install-fish-shell, which installs from the + Launchpad PPA on Linux. When the PPA is down (it returns 503s at times), + `apt-get update` only warns and `apt-get install fish` silently installs + Ubuntu's own, much older fish instead. That one prints "Could not set up + terminal" warnings on the runner, which the prompt tests count as stray + output. GitHub release downloads don't depend on Launchpad, and the + version is pinned. /usr/bin is where fish-shop/install-plugin-manager + expects fish. inputs: version: -- knotmirror 0.0.1