Something went wrong. Try again.
A lexicon-driven AppView for ATProto. forked from gamesgamesgamesgames.games/happyview
Something went wrong. Try again.
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433use mlua::{Lua, LuaSerdeExt, Result as LuaResult};
use super::tid::{ generate_tid, tid_from_iso8601, tid_from_number, tid_from_unix_microseconds, tid_to_iso8601, tid_to_number, tid_to_unix_microseconds,};
const INSTRUCTION_LIMIT: u32 = 1_000_000;
/// Create a fresh sandboxed Lua VM.////// - Dangerous globals (`io`, `debug`, `package`, `require`, `dofile`, `loadfile`, `load`) are removed./// - `os` is replaced with a safe subset exposing only `time`, `date`, `difftime`, and `clock`./// - An instruction-count hook prevents infinite loops./// - Utility globals `now()` and `log()` are injected.pub fn create_sandbox() -> LuaResult<Lua> { let lua = Lua::new();
// Preserve safe os functions before removing the full os table let globals = lua.globals(); let safe_os = lua.create_table()?; if let Ok(os_table) = globals.get::<mlua::Table>("os") { for name in &["time", "date", "difftime", "clock"] { if let Ok(func) = os_table.get::<mlua::Function>(*name) { safe_os.set(*name, func)?; } } }
// Remove dangerous globals for name in &[ "os", "io", "debug", "package", "require", "dofile", "loadfile", "load", "collectgarbage", ] { globals.raw_set(*name, mlua::Value::Nil)?; }
// Re-add os with only safe functions (time, date, difftime, clock) globals.set("os", safe_os)?;
// Instruction limit to prevent infinite loops lua.set_hook( mlua::HookTriggers::new().every_nth_instruction(INSTRUCTION_LIMIT), |_lua, _debug| Err(mlua::Error::runtime("script exceeded execution limit")), )?;
// Utility: now() returns UTC ISO 8601 string let now_fn = lua.create_function(|_, ()| Ok(chrono::Utc::now().to_rfc3339()))?; globals.set("now", now_fn)?;
// `log(message)` no-op stub. The real implementation lives in // `super::scripts::register_log_event_api` and is registered by // every runner so the trigger context can be threaded into each // `event_logs` row. The stub here exists only so paths that exec // a script body OUTSIDE a runner — namely `validate_script` // (admin write-time linting) and the in-process xrpc_api tests — // don't break on top-level `log("...")` calls in user scripts. // The runner-level registration always overrides this stub. let log_fn = lua.create_function(|_, _msg: String| Ok(()))?; globals.set("log", log_fn)?;
// Utility: TID table — callable as TID() to generate, plus conversion methods let tid_table = lua.create_table()?; tid_table.set( "toISO8601", lua.create_function(|_, tid: String| { tid_to_iso8601(&tid).ok_or_else(|| mlua::Error::runtime(format!("invalid TID: {tid}"))) })?, )?; tid_table.set( "fromISO8601", lua.create_function(|_, iso: String| { tid_from_iso8601(&iso) .ok_or_else(|| mlua::Error::runtime(format!("invalid ISO 8601: {iso}"))) })?, )?; tid_table.set( "toUnixMicroseconds", lua.create_function(|_, tid: String| { tid_to_unix_microseconds(&tid) .ok_or_else(|| mlua::Error::runtime(format!("invalid TID: {tid}"))) })?, )?; tid_table.set( "fromUnixMicroseconds", lua.create_function(|_, us: i64| Ok(tid_from_unix_microseconds(us)))?, )?; tid_table.set( "toNumber", lua.create_function(|_, tid: String| { tid_to_number(&tid) .map(|v| v as i64) .ok_or_else(|| mlua::Error::runtime(format!("invalid TID: {tid}"))) })?, )?; tid_table.set( "fromNumber", lua.create_function(|_, val: i64| Ok(tid_from_number(val as u64)))?, )?; let tid_meta = lua.create_table()?; tid_meta.set( "__call", lua.create_function(|_, _: mlua::MultiValue| Ok(generate_tid()))?, )?; let _ = tid_table.set_metatable(Some(tid_meta)); globals.set("TID", tid_table)?;
// Utility: toarray(table) marks a table as a JSON array for serialization. // Ensures empty tables serialize as [] instead of {}. let toarray_fn = lua.create_function(|lua, table: mlua::Table| { let values: Vec<mlua::Value> = table.sequence_values().collect::<LuaResult<_>>()?; let seq = lua.create_sequence_from(values)?; seq.set_metatable(Some(lua.array_metatable()))?; Ok(seq) })?; globals.set("toarray", toarray_fn)?;
// JSON utilities: json.encode(table) -> string, json.decode(string) -> table let json_table = lua.create_table()?;
let encode_fn = lua.create_function(|lua, value: mlua::Value| { let json_value: serde_json::Value = lua .from_value(value) .map_err(|e| mlua::Error::runtime(format!("json.encode: {e}")))?; serde_json::to_string(&json_value) .map_err(|e| mlua::Error::runtime(format!("json.encode: {e}"))) })?; json_table.set("encode", encode_fn)?;
let decode_fn = lua.create_function(|lua, s: String| { let json_value: serde_json::Value = serde_json::from_str(&s) .map_err(|e| mlua::Error::runtime(format!("json.decode: {e}")))?; lua.to_value(&json_value) .map_err(|e| mlua::Error::runtime(format!("json.decode: {e}"))) })?; json_table.set("decode", decode_fn)?;
globals.set("json", json_table)?;
Ok(lua)}
/// Validate that a script compiles and defines a `handle` function.pub fn validate_script(source: &str) -> Result<(), String> { let lua = create_sandbox().map_err(|e| format!("failed to create Lua VM: {e}"))?; // Set a stub env table that returns "" for any missing key so scripts // that do top-level concatenation (e.g. `env.URL .. "/path"`) don't fail. let env_stub = lua.create_table().unwrap(); let meta = lua.create_table().unwrap(); meta.set( "__index", lua.create_function(|_, (_t, _k): (mlua::Value, mlua::Value)| Ok("".to_string())) .unwrap(), ) .unwrap(); let _ = env_stub.set_metatable(Some(meta)); lua.globals() .set("env", env_stub) .map_err(|e| format!("failed to set env stub: {e}"))?; lua.load(source) .exec() .map_err(|e| format!("script compilation failed: {e}"))?;
let globals = lua.globals(); match globals.get::<mlua::Function>("handle") { Ok(_) => Ok(()), Err(_) => Err("script must define a handle() function".into()), }}
#[cfg(test)]mod tests { use super::*;
#[test] fn sandbox_removes_dangerous_globals() { let lua = create_sandbox().unwrap(); let globals = lua.globals(); assert!(globals.get::<mlua::Value>("io").unwrap().is_nil()); assert!(globals.get::<mlua::Value>("debug").unwrap().is_nil()); assert!(globals.get::<mlua::Value>("package").unwrap().is_nil()); assert!(globals.get::<mlua::Value>("require").unwrap().is_nil()); }
#[test] fn sandbox_provides_safe_os_subset() { let lua = create_sandbox().unwrap(); let os_table: mlua::Table = lua.globals().get("os").unwrap(); assert!(os_table.get::<mlua::Function>("time").is_ok()); assert!(os_table.get::<mlua::Function>("date").is_ok()); assert!(os_table.get::<mlua::Function>("difftime").is_ok()); assert!(os_table.get::<mlua::Function>("clock").is_ok()); // Dangerous os functions should not be present assert!(os_table.get::<mlua::Value>("execute").unwrap().is_nil()); assert!(os_table.get::<mlua::Value>("remove").unwrap().is_nil()); assert!(os_table.get::<mlua::Value>("rename").unwrap().is_nil()); assert!(os_table.get::<mlua::Value>("exit").unwrap().is_nil()); }
#[test] fn sandbox_provides_now() { let lua = create_sandbox().unwrap(); let result: String = lua.load("return now()").eval().unwrap(); assert!(result.contains("T")); // ISO 8601 format }
#[test] fn sandbox_provides_log() { let lua = create_sandbox().unwrap(); lua.load(r#"log("test message")"#).exec().unwrap(); }
#[test] fn sandbox_provides_tid() { let lua = create_sandbox().unwrap(); let result: String = lua.load("return TID()").eval().unwrap(); assert_eq!(result.len(), 13); let valid = "234567abcdefghijklmnopqrstuvwxyz"; for ch in result.chars() { assert!(valid.contains(ch), "invalid char '{ch}' in TID"); } }
#[test] fn sandbox_tid_returns_unique_values() { let lua = create_sandbox().unwrap(); let a: String = lua.load("return TID()").eval().unwrap(); let b: String = lua.load("return TID()").eval().unwrap(); assert_ne!(a, b); }
#[test] fn sandbox_tid_to_iso8601() { let lua = create_sandbox().unwrap(); let iso: String = lua.load(r#"return TID.toISO8601(TID())"#).eval().unwrap(); assert!(iso.contains("T") && iso.ends_with("Z")); }
#[test] fn sandbox_tid_from_iso8601() { let lua = create_sandbox().unwrap(); let tid: String = lua .load(r#"return TID.fromISO8601("2024-01-01T00:00:00Z")"#) .eval() .unwrap(); assert_eq!(tid.len(), 13); }
#[test] fn sandbox_tid_roundtrip() { let lua = create_sandbox().unwrap(); let result: String = lua .load( r#" local tid = TID() local iso = TID.toISO8601(tid) local tid2 = TID.fromISO8601(iso) return TID.toISO8601(tid2) "#, ) .eval() .unwrap(); assert!(result.contains("T") && result.ends_with("Z")); }
#[test] fn sandbox_tid_to_unix_microseconds() { let lua = create_sandbox().unwrap(); let us: i64 = lua .load(r#"return TID.toUnixMicroseconds(TID.fromISO8601("2024-01-01T00:00:00Z"))"#) .eval() .unwrap(); assert_eq!(us, 1_704_067_200_000_000); }
#[test] fn sandbox_tid_from_unix_microseconds() { let lua = create_sandbox().unwrap(); let tid: String = lua .load("return TID.fromUnixMicroseconds(1704067200000000)") .eval() .unwrap(); assert_eq!(tid.len(), 13); let iso: String = lua .load(format!(r#"return TID.toISO8601("{tid}")"#)) .eval() .unwrap(); assert_eq!(iso, "2024-01-01T00:00:00.000000Z"); }
#[test] fn sandbox_tid_number_lossless_roundtrip() { let lua = create_sandbox().unwrap(); let result: bool = lua .load( r#" local tid = TID() local n = TID.toNumber(tid) local tid2 = TID.fromNumber(n) return tid == tid2 "#, ) .eval() .unwrap(); assert!(result, "toNumber/fromNumber should be lossless"); }
#[test] fn sandbox_tid_to_iso8601_errors_on_invalid() { let lua = create_sandbox().unwrap(); let result = lua .load(r#"return TID.toISO8601("garbage")"#) .eval::<String>(); assert!(result.is_err()); }
#[test] fn sandbox_tid_from_iso8601_errors_on_invalid() { let lua = create_sandbox().unwrap(); let result = lua .load(r#"return TID.fromISO8601("not a date")"#) .eval::<String>(); assert!(result.is_err()); }
#[test] fn sandbox_kills_infinite_loop() { let lua = create_sandbox().unwrap(); let result = lua.load("while true do end").exec(); assert!(result.is_err()); let err = result.unwrap_err().to_string(); assert!( err.contains("execution limit"), "expected execution limit error, got: {err}" ); }
#[test] fn validate_script_accepts_valid() { let result = validate_script("function handle() return {} end"); assert!(result.is_ok()); }
#[test] fn validate_script_rejects_missing_handle() { let result = validate_script("function other() return {} end"); assert!(result.is_err()); assert!(result.unwrap_err().contains("handle")); }
#[test] fn validate_script_rejects_syntax_error() { let result = validate_script("function handle("); assert!(result.is_err()); }
#[test] fn sandbox_provides_toarray() { let lua = create_sandbox().unwrap(); lua.load(r#"result = toarray({})"#).exec().unwrap(); }
#[test] fn sandbox_toarray_preserves_values() { let lua = create_sandbox().unwrap(); let result: Vec<i64> = lua .load(r#"return toarray({10, 20, 30})"#) .eval::<mlua::Table>() .unwrap() .sequence_values() .collect::<LuaResult<_>>() .unwrap(); assert_eq!(result, vec![10, 20, 30]); }
#[test] fn sandbox_toarray_empty_serializes_as_array() { use mlua::LuaSerdeExt; let lua = create_sandbox().unwrap(); let table: mlua::Table = lua.load(r#"return toarray({})"#).eval().unwrap(); let json: serde_json::Value = lua.from_value(mlua::Value::Table(table)).unwrap(); assert!(json.is_array(), "expected JSON array, got: {json}"); }
#[test] fn sandbox_provides_json_encode() { let lua = create_sandbox().unwrap(); let result: String = lua .load(r#"return json.encode({name = "test", count = 42})"#) .eval() .unwrap(); let parsed: serde_json::Value = serde_json::from_str(&result).unwrap(); assert_eq!(parsed["name"], "test"); assert_eq!(parsed["count"], 42); }
#[test] fn sandbox_provides_json_decode() { let lua = create_sandbox().unwrap(); let result: mlua::Table = lua .load(r#"return json.decode('{"name":"test","count":42}')"#) .eval() .unwrap(); assert_eq!(result.get::<String>("name").unwrap(), "test"); assert_eq!(result.get::<i64>("count").unwrap(), 42); }
#[test] fn sandbox_json_encode_array() { let lua = create_sandbox().unwrap(); let result: String = lua .load(r#"return json.encode(toarray({1, 2, 3}))"#) .eval() .unwrap(); assert_eq!(result, "[1,2,3]"); }
#[test] fn sandbox_json_decode_invalid_returns_error() { let lua = create_sandbox().unwrap(); let result: Result<mlua::Value, _> = lua.load(r#"return json.decode("not valid json")"#).eval(); assert!(result.is_err()); }}